KKcorps commented on code in PR #19115:
URL: https://github.com/apache/pinot/pull/19115#discussion_r3680203949
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerTest.java:
##########
@@ -2032,7 +2032,7 @@ public void testPartialUpsertSameDocsReplacement() throws
IOException {
// Test partial upserts with old and new segments having same number of
docs
// This test verifies that when all keys are present, no reversion occurs
PartialUpsertHandler mockPartialUpsertHandler =
mock(PartialUpsertHandler.class);
- UpsertContext upsertContext =
_contextBuilder.setPartialUpsertHandler(mockPartialUpsertHandler)
Review Comment:
I haven't done that because that test is probabilistic. We won't be able
reliably reproduce the bug in 100% of the scenarios and thus add flakiness to
our test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
