KKcorps commented on code in PR #19115: URL: https://github.com/apache/pinot/pull/19115#discussion_r3680469593
########## pinot-common/src/main/java/org/apache/pinot/common/evaluator/InbuiltFunctionEvaluator.java: ########## @@ -42,6 +42,8 @@ * <li>ColumnNode - fetches the value of the column from the input GenericRow</li> * <li>ConstantNode - returns the literal value</li> * </ul> + * <p>NOTE: This class is not thread safe. Function nodes refill one reusable argument array on every evaluation, so Review Comment: Added @NotThreadSafe to InbuiltFunctionEvaluator, and applied the same annotation to ExpressionTransformer and PartialUpsertHandler because this PR documents all three as instance-confined. Included in e7bc2c3cc9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
