Jackie-Jiang commented on code in PR #18872:
URL: https://github.com/apache/pinot/pull/18872#discussion_r3706594008


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -117,13 +118,18 @@ public void init(List<TransformFunction> arguments, 
Map<String, ColumnContext> c
         case STRING:
           _valueSet = stringValues;
           break;
-        case BYTES:
+        case BYTES: {
+          // UUID and BYTES differ only in how the literal is parsed -- 
canonical UUID text vs hex. The stored form,
+          // and therefore the lookup below, is identical.
+          boolean isUuid = _mainFunction.getResultMetadata().getDataType() == 
DataType.UUID;

Review Comment:
   Why is there no special handling on BOOLEAN and TIMESTAMP?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to