Jackie-Jiang commented on code in PR #18872:
URL: https://github.com/apache/pinot/pull/18872#discussion_r3706639710
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/ArrayCopyUtils.java:
##########
@@ -228,6 +228,22 @@ public static void copyFromTimestamp(long[] src, String[]
dest, int length) {
}
}
+ /// Renders UUID values, stored as 16 raw bytes, into their canonical dashed
form. Mirrors
+ /// [#copyFromTimestamp(long[], String[], int)], which likewise renders a
logical type from its stored form.
+ public static void copyFromUuid(byte[][] src, String[] dest, int length) {
Review Comment:
Move the methods added to the right place. We follow the src/dest type order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
