Copilot commented on code in PR #18976:
URL: https://github.com/apache/pinot/pull/18976#discussion_r3717366003
##########
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONMessageDecoder.java:
##########
@@ -46,6 +48,14 @@ public void init(Map<String, String> props, Set<String>
fieldsToRead, String top
if (recordExtractorClass == null) {
Review Comment:
JSONMessageDecoder.init() currently always calls
_jsonRecordExtractor.init(fieldsToRead, null), ignoring
StreamMessageDecoder.RECORD_EXTRACTOR_CONFIG_CONFIG_KEY
(recordExtractorConfigClass). Other decoders (e.g., Avro) honor this and pass a
RecordExtractorConfig initialized from props; leaving it null here prevents
configuring custom JSON extractors and makes decoder behavior inconsistent
across formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
