Vamsi-klu commented on code in PR #18976:
URL: https://github.com/apache/pinot/pull/18976#discussion_r3725704764
##########
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONMessageDecoder.java:
##########
@@ -46,6 +48,14 @@ public void init(Map<String, String> props, Set<String>
fieldsToRead, String top
if (recordExtractorClass == null) {
Review Comment:
The observation is accurate, but this behavior is pre-existing rather than
introduced here. The _jsonRecordExtractor.init(fieldsToRead, null) call is
unchanged from master; this PR's changes to init() only add the
preserveDecimalPrecision handling. Wiring up recordExtractorConfigClass would
mean instantiating the config class and initializing it from props the way
SimpleAvroMessageDecoder does, which is orthogonal to BigDecimal precision. I
would prefer to keep this PR focused and address the extractor config support
in a separate follow-up PR if the maintainers want it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
