xiangfu0 commented on PR #19307: URL: https://github.com/apache/pinot/pull/19307#issuecomment-5722290683
Rebased the stack onto current master (it had fallen 88 commits behind); no conflicts at this level, and the three commits are unchanged in content. All 11 review threads here are resolved, and the two whose replies had gone stale were corrected above with what the code actually does. Stack, each based on its predecessor: #19307 (V7 format) → #19308 (reload + enable) → #19309 (integration tests + docs). #19308 was conflicting against the new master and is now clean. This is still carrying your `CHANGES_REQUESTED` from Aug 29 — whenever you have a moment, another look would unblock the rest of the stack. The two items I deliberately left for a codec-module follow-up rather than growing this PR are the cross-segment plan cache and the per-call heap scratch in `T64CodecDefinition.encode` (~786 KB/op on `DELTA,T64,LZ4` at 1M rows); both are in the codec package this PR does not touch, per your earlier request to keep codec changes separate. _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
