xiangfu0 commented on PR #19770: URL: https://github.com/apache/pinot/pull/19770#issuecomment-6067043479
Addressed [the simplification review](https://github.com/apache/pinot/pull/19770#pullrequestreview-5461251862) in [89f6f0dc7d](https://github.com/apache/pinot/commit/89f6f0dc7da4f65e566bdbbfd445132688c28803). - Switched retained/projected byte accounting to `long` and removed the synthetic overflow test. - Filter candidate metadata directly, with a `HashSet` for last-completed LLC names and direct hybrid-boundary filtering. - Consolidated disabled-policy and failure/retry tests into the real-registry lifecycle test. It covers both REFRESH and unset policies, registry absence, exact gauge publication and deletion counts, reconfiguration, and leadership cleanup. Removed the null-response scenario and guard; the production deletion API always returns a response. All 79 targeted tests passed with no failures, errors, or skips, including 58 `RetentionManagerTest` cases. Scoped Spotless, Checkstyle, and license checks passed, with no compiler warnings on added lines. The PR description has been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
