xiangfu0 commented on code in PR #19795: URL: https://github.com/apache/pinot/pull/19795#discussion_r4225312366
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/customobject/TDigest.java: ########## @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.customobject; + +import java.nio.ByteBuffer; +import java.util.Collection; +import java.util.List; + +/// Mutable percentile digest contract for aggregation plugins and legacy t-digest byte encodings. +/// Implementations are not thread-safe; callers must serialize access to each aggregation state. +/// Fractional mass is preserved; t-digest 3.3 can reject endpoint weights below one or singleton masses between +/// one and two during recompression because its endpoint invariant requires unit weights. +public abstract class TDigest { Review Comment: Addressed in 14657b2cfb. Considered this and kept the shared TDigest contract for the native accumulator, the non-finite wrapper, and generic conforming producers. Serialization accepts that contract; decoding selects the canonical implementation for the fixed legacy wire format. QuantileDigest is a concrete implementation, whereas this is their shared abstraction. Moving it and trimming the surface is feasible, but would add API/module churn to this compatibility fix; SPI signatures are unchanged in this round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
