xiangfu0 commented on code in PR #19795:
URL: https://github.com/apache/pinot/pull/19795#discussion_r4225309998
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/customobject/PercentileTDigestAccumulator.java:
##########
@@ -1194,7 +1292,7 @@ private static int normalizeBoundaries(double[] means,
double[] weights, int cou
}
if (count == 1) {
double weight = weights[0];
- if (weight <= 1.0) {
+ if (weight < 2.0) {
Review Comment:
Addressed in 14657b2cfb. Fresh legacy serialization now rejects sub-unit
endpoint mass and fractional singleton mass below two instead of changing its
mass or writing a payload that fails the old reader's assertions. In-memory
fractional quantiles remain supported, and unchanged historical bytes survive
views, compression, copying, and returned-array mutation. The actual 3.3 reader
with -ea reproduces the 1.5 singleton restriction. Follow-up 54d2ef248b also
preserves those unchanged bytes through generic Serde and SerializedTDigest
rendering. Exact private-wrapper provenance is required, and finite-only
provenance is used only with zero infinity tails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
