xiangfu0 commented on code in PR #19795:
URL: https://github.com/apache/pinot/pull/19795#discussion_r4240091594
##########
.github/workflows/pinot_unit_tests.yml:
##########
@@ -163,6 +163,10 @@ jobs:
timeout-minutes: 120
run: |
.github/workflows/scripts/pr-tests/.pinot_tests_unit.sh
+ - name: Verify legacy t-digest readers
+ if: ${{ matrix.testset == 2 }}
Review Comment:
Fixed in
[df09e87b8f](https://github.com/apache/pinot/commit/df09e87b8f99948e03442cb3afbb887b3100dc5d).
The workflow now selects the compatibility step by fixture-manifest presence
instead of test-set number, so it follows LegacyTDigestCompatibilityTest when
modules move between shards. Removed the hand-synchronized fixture totals; both
readers iterate their manifests and require nonempty input plus actual quantile
comparisons. Verified by adding an extra fixture without changing code: the
legacy reader processed 40 cases and the reverse Pinot reader processed 83.
Missing/empty manifests still fail standalone run.sh, and actionlint passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
