Jackie-Jiang commented on code in PR #20097:
URL: https://github.com/apache/pinot/pull/20097#discussion_r4418589157
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -554,6 +557,9 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
// NOTE: Monitor the segments to be moved from both the previous round and
this round to ensure the moved segments
// in the previous round are also converged.
List<String> oldSegmentsToMove = segmentsToMove;
+ // Force commit each partition's consuming segments at most once during
this rebalance. A force commit creates
+ // a consuming successor in the same partition, which must not be
committed again on retries or later steps.
+ IntSet forceCommittedPartitions = new IntOpenHashSet();
Review Comment:
This is intentional: each partition selected for movement should be
force-committed once during the rebalance. Later steps may replay more records;
we accept that tradeoff to avoid repeated forced rollovers. The code comment,
tests, and PR description now reflect this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
