xiangfu0 commented on code in PR #20112:
URL: https://github.com/apache/pinot/pull/20112#discussion_r4486123403
##########
pinot-plugins/pinot-input-format/pinot-json/README.md:
##########
@@ -96,7 +96,7 @@ All examples use a Kafka real-time table; substitute your
stream type (`stream.<
"streamType": "kafka",
"stream.kafka.topic.name": "events",
"stream.kafka.decoder.class.name":
"org.apache.pinot.plugin.inputformat.json.JSONMessageDecoder",
- "stream.kafka.consumer.factory.class.name":
"org.apache.pinot.plugin.stream.kafka30.KafkaConsumerFactory",
+ "stream.kafka.consumer.factory.class.name":
"org.apache.pinot.plugin.stream.kafka40.KafkaConsumerFactory",
Review Comment:
Fixed in 10fe73e086. Removed the explicit factory key from both ordinary
JSON examples so each component uses its own default during rolling upgrades.
Both full examples parse successfully. The custom factory override and
intentional optional-value example in the migration guide are preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
