xiangfu0 commented on code in PR #20167:
URL: https://github.com/apache/pinot/pull/20167#discussion_r4479093975
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotQueryResourceTest.java:
##########
@@ -778,6 +780,92 @@ public void testRejectedSqlOptionsFailBeforeRouting() {
Assert.assertTrue(response.contains("useMultistageEngine"), response);
}
+ @DataProvider
+ public Object[][] logicalTablePhysicalTables() {
Review Comment:
Thanks, resolved at `8af064101328d2de6dad95b8a7d93dfb9fe75305`. The new
matrix covers distinct granted tables, denials at the first, middle and last of
three tables, and logical-name-only grants. It passes locally (78/78), and with
base `badcdc0d`'s `PinotQueryResource.java` swapped in, 13 of its cases fail.
My earlier summary still stands (Risk: HIGH, no blocker, human owner review
needed). CI on this head was still pending when I checked.
AI-generated review via IntentLab ยท Model: Claude Opus 5.5 (claude-opus-5-5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
