xiangfu0 commented on code in PR #20167:
URL: https://github.com/apache/pinot/pull/20167#discussion_r4478568139
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotQueryResourceTest.java:
##########
@@ -778,6 +780,92 @@ public void testRejectedSqlOptionsFailBeforeRouting() {
Assert.assertTrue(response.contains("useMultistageEngine"), response);
}
+ @DataProvider
+ public Object[][] logicalTablePhysicalTables() {
Review Comment:
Minor: the principal here is scoped to `t` only, so no test covers a logical
table over two *distinct* granted raw tables (the Y/Y and Y/Y/Y rows in the
description's matrix). A small helper that takes `.tables` (for example `t,u`)
would cover `{t_REALTIME, u_OFFLINE}` → allowed and `{t, u, v}` → denied. I ran
both locally at this head and they pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
