xiangfu0 commented on code in PR #20112:
URL: https://github.com/apache/pinot/pull/20112#discussion_r4477265446
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-4.0/pom.xml:
##########
@@ -58,6 +52,13 @@
</exclusions>
</dependency>
+ <!-- Kafka's OAuth callback needs jose4j, which kafka-clients does not
supply transitively. -->
+ <dependency>
+ <groupId>org.bitbucket.b_c</groupId>
+ <artifactId>jose4j</artifactId>
Review Comment:
Added KafkaOAuthRuntimeTest in da486c656b6889ff3b220e9b0911248d76bab76c.
Maven generates this module's runtime classpath, and the test starts a fresh
JVM that constructs both validators through Kafka's actual
constructor-resolution API, with no test-kit/server jars or network access.
Removing only the runtime jose4j dependency while retaining the test kit
reproduces VerificationKeyResolver NoClassDefFoundError; restoring it passes.
The focused reactor, formatting, Checkstyle and license checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
