KKcorps commented on code in PR #20137:
URL: https://github.com/apache/pinot/pull/20137#discussion_r4585930849


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -306,6 +317,8 @@ public void deleteSegmentFile() {
   private volatile boolean _hasMessagesFetched = false;
   private volatile boolean _endOfPartitionGroup = false;
   private volatile boolean _forceCommitMessageReceived = false;
+  // Notified by forceCommit() to wake a decode retry backoff, so the segment 
ends without waiting it out
+  private final Object _decodeRetryBackoffLock = new Object();

Review Comment:
   Let's use a proper lock here and check if this is really needed or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to