anshul98ks123 commented on code in PR #20137:
URL: https://github.com/apache/pinot/pull/20137#discussion_r4586130909
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -306,6 +317,8 @@ public void deleteSegmentFile() {
private volatile boolean _hasMessagesFetched = false;
private volatile boolean _endOfPartitionGroup = false;
private volatile boolean _forceCommitMessageReceived = false;
+ // Notified by forceCommit() to wake a decode retry backoff, so the segment
ends without waiting it out
+ private final Object _decodeRetryBackoffLock = new Object();
Review Comment:
Switched to a `ReentrantLock` with a `Condition` in 0504b71e6b. It is
needed: without the wake, a force commit or pause that arrives during a backoff
waits out the rest of the sleep, up to `decodeRetryMaxBackoffMillis` (10 s by
default). Live, force commit went from 5.7–7.2 s to 1.3 s, and
`testForceCommitWakesTheDecodeRetryBackoff` fails without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]