siddharthteotia commented on a change in pull request #4993: Support Text
Search (both offline and realtime)
URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368072349
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -281,10 +334,14 @@ public long getLatestIngestionTimestamp() {
* @param column column name
* @return true if column is no-dictionary, false if dictionary encoded
*/
- private boolean isNoDictionaryColumn(Set<String> noDictionaryColumns,
Set<String> invertedIndexColumns,
- FieldSpec fieldSpec, String column) {
- return noDictionaryColumns.contains(column) &&
fieldSpec.isSingleValueField()
- && !invertedIndexColumns.contains(column);
+ private boolean isNoDictionaryColumn(
Review comment:
Done -- I explicitly added the arguments in separate line as without
indentation, functions with multiple arguments look a bit ugly. Reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
