siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368135253
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/LuceneIndexScanDocIdIterator.java ########## @@ -0,0 +1,90 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.dociditerators; + +import org.apache.lucene.document.Document; +import org.apache.lucene.search.IndexSearcher; +import org.apache.pinot.core.common.Constants; +import org.apache.pinot.core.segment.creator.impl.V1Constants; +import org.apache.pinot.core.segment.index.readers.text.LuceneIndexSearcherReferenceManager; +import org.apache.pinot.core.segment.index.readers.text.LuceneTextIndexReader; +import org.roaringbitmap.IntIterator; + + +public class LuceneIndexScanDocIdIterator implements IndexBasedDocIdIterator { + + private int _currentDocId = -1; + private int _startDocId; + private int _endDocId; + private final IntIterator _docIDIterator; + private final IndexSearcher _indexSearcher; + private final LuceneIndexSearcherReferenceManager _searcherReferenceManager; + private final int _numDocs; + + public LuceneIndexScanDocIdIterator(LuceneTextIndexReader.LuceneSearchResult luceneSearchResult) { + _docIDIterator = luceneSearchResult.getDocIDs().getIntIterator(); Review comment: Discussed offline. It is better to iterate over the lucene doc id set upfront and build the bitmap with actual pinot doc ids and then have rest of the filter processing work off that bimap since then we can do fast intersection for multi-predicate query which is either leveraging native Pinot inverted index or another text_match predicate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
