mcvsubbu commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368336179
########## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/invertedindex/RealtimeLuceneTextIndexReader.java ########## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.realtime.impl.invertedindex; + +import java.io.File; +import org.apache.lucene.analysis.standard.StandardAnalyzer; +import org.apache.lucene.index.IndexWriter; +import org.apache.lucene.queryparser.classic.QueryParser; +import org.apache.lucene.search.Collector; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.Query; +import org.apache.lucene.search.SearcherManager; +import org.apache.pinot.core.common.Predicate; +import org.apache.pinot.core.common.predicate.TextMatchPredicate; +import org.apache.pinot.core.segment.creator.impl.inv.text.LuceneTextIndexCreator; +import org.apache.pinot.core.segment.index.readers.InvertedIndexReader; +import org.apache.pinot.core.segment.index.readers.text.LuceneDocIdCollector; +import org.apache.pinot.core.segment.index.readers.text.LuceneIndexSearcherReferenceManager; +import org.apache.pinot.core.segment.index.readers.text.LuceneTextIndexReader; +import org.roaringbitmap.buffer.MutableRoaringBitmap; + + +/** + * Lucene text index reader supporting near realtime search. An instance of this + * is created per consuming segment by {@link org.apache.pinot.core.indexsegment.mutable.MutableSegmentImpl}. + * Internally it uses {@link LuceneTextIndexCreator} for adding documents to the lucene index + * as and when they are indexed by the consuming segment. + */ +public class RealtimeLuceneTextIndexReader implements InvertedIndexReader<LuceneTextIndexReader.LuceneSearchResult> { + private final QueryParser _queryParser; + private final LuceneTextIndexCreator _indexCreator; + private volatile SearcherManager _searcherManager; Review comment: why is this volatile? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
