siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368180500
########## File path: pinot-common/src/main/antlr4/org/apache/pinot/pql/parsers/PQL2.g4 ########## @@ -95,6 +96,9 @@ betweenClause: regexpLikeClause: REGEXP_LIKE '(' expression ',' literal ')'; +textMatchClause: Review comment: We need to extend the Calcite grammar and parser to make its compiler recognize TEXT_MATCH as a valid token. This way a SQL query on Pinot that has text_match() predicate(s) and goes down the Calcite compiler path to build PinotQuery will work perfectly ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org