Jackie-Jiang commented on a change in pull request #5114: Bugfixing the issue 
for ThreadLocal DocIdSet in ExpressionFilterOperator
URL: https://github.com/apache/incubator-pinot/pull/5114#discussion_r388058619
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/operator/DocIdSetOperator.java
 ##########
 @@ -69,7 +75,7 @@ protected DocIdSetBlock getNextBlock() {
     }
 
     int pos = 0;
-    int[] docIds = THREAD_LOCAL_DOC_IDS.get();
+    int[] docIds = _threadLocal? THREAD_LOCAL_DOC_IDS.get(): new 
int[DocIdSetPlanNode.MAX_DOC_PER_CALL];
 
 Review comment:
   ```suggestion
       int[] docIds = _threadLocal? THREAD_LOCAL_DOC_IDS.get(): new 
int[_maxSizeOfDocIdSet];
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to