Jackie-Jiang commented on a change in pull request #5114: Bugfixing the issue
for ThreadLocal DocIdSet in ExpressionFilterOperator
URL: https://github.com/apache/incubator-pinot/pull/5114#discussion_r388058386
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/ExpressionFilterOperator.java
##########
@@ -196,7 +196,7 @@ public BlockDocIdIterator iterator() {
int _endDocId;
//used only in next() and advance methods
int _currentBlockStartDocId = -1;
- int _currentBlockEndDocId = 0;
+ int _currentBlockEndDocId = -1;
Review comment:
I would recommend making both endDocId and this exclusive. Currently the
numDocsScanned value is incorrect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
