mcvsubbu commented on a change in pull request #5221: Add a new server api for 
download of segments.
URL: https://github.com/apache/incubator-pinot/pull/5221#discussion_r405187457
 
 

 ##########
 File path: 
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
 ##########
 @@ -175,4 +183,41 @@ public String getCrcMetadataForTable(
       }
     }
   }
+
+  @GET
+  @Produces(MediaType.APPLICATION_OCTET_STREAM)
+  @Path("/tables/{tableName}/segments/{segmentName}")
 
 Review comment:
   this path is the deprecated one in the controller. Can we use the same as 
what the controller uses?
   `/segments/{tableName}/{segmentName}`. Please add this as a discussion point 
in your doc, and start an email discussion on this spec. Within a couple of 
days, we can get any feedback people may have

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to