mcvsubbu commented on a change in pull request #5221: Add a new server api for
download of segments.
URL: https://github.com/apache/incubator-pinot/pull/5221#discussion_r405190771
##########
File path:
pinot-server/src/test/java/org/apache/pinot/server/api/BaseResourceTest.java
##########
@@ -55,11 +56,12 @@
public abstract class BaseResourceTest {
private static final String AVRO_DATA_PATH = "data/test_data-mv.avro";
private static final File INDEX_DIR = new File(FileUtils.getTempDirectory(),
"BaseResourceTest");
- protected static final String TABLE_NAME = "testTable";
+ protected static final String REALTIME_TABLE_NAME = "testTable_REALTIME";
Review comment:
nit: Use the TableNameBuilder. let TABLE_NAME still be there, and you can
use the builder to derive the other two
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
