npawar commented on a change in pull request #5324:
URL: https://github.com/apache/incubator-pinot/pull/5324#discussion_r419634660
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/function/DateTimeFunctions.java
##########
@@ -35,9 +63,79 @@ static Long toEpochHours(Long millis) {
}
/**
- * Convert epoch millis to epoch minutes, bucketed by given bucket
granularity
+ * Convert epoch millis to epoch hours, bucketed by given bucket granularity
*/
- static Long toEpochMinutes(Long millis, String bucket) {
- return TimeUnit.MILLISECONDS.toMinutes(millis) / Integer.parseInt(bucket);
+ static Long toEpochHoursBucket(Long millis, String bucket) {
+ return TimeUnit.MILLISECONDS.toHours(millis) / Integer.parseInt(bucket);
Review comment:
Ah didn't know about the caching done by valueOf. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
