npawar commented on a change in pull request #5324:
URL: https://github.com/apache/incubator-pinot/pull/5324#discussion_r419635708
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -631,4 +632,130 @@ public int hashCode() {
result = EqualityUtils.hashCodeOf(result, _dateTimeFieldSpecs);
return result;
}
+
+ /**
+ * Helper method that converts a {@link TimeFieldSpec} to {@link
DateTimeFieldSpec}
+ * 1) If timeFieldSpec contains only incoming granularity spec, directly
convert it to a dateTimeFieldSpec
+ * 2) If timeFieldSpec contains incoming aas well as outgoing granularity
spec, use the outgoing spec to construct the dateTimeFieldSpec,
+ * and configure a transform function for the conversion from incoming
+ */
+ @VisibleForTesting
+ static DateTimeFieldSpec convertToDateTimeFieldSpec(TimeFieldSpec
timeFieldSpec) {
Review comment:
My intention was to do the first of your options. I chose the "default"
access modifier instead of protected, as it's one level more restrictive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
