npawar commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-pinot/pull/5635#discussion_r447149963
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentOrderBySingleValueQueriesTest.java
##########
@@ -165,7 +162,7 @@ public void testQueryOptions() {
new Object[]{query, results, numDocsScanned,
numEntriesScannedInFilter, numEntriesScannedPostFilter, numTotalDocs,
dataSchema});
// order by one of the group by columns DESC
- query = "SELECT sum(column1) FROM testTable GROUP BY column11 ORDER BY
column11 DESC";
+ query = "SELECT column11, sum(column1) FROM testTable GROUP BY column11
ORDER BY column11 DESC";
Review comment:
this was using the pql endpoint with options because we were not ready
for the sql parser. i changed it to use SQL endpoint. In sql endpoint if column
is expecetd in results, then it needs to be in the selection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
