npawar commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-pinot/pull/5635#discussion_r447154811
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentOrderByMultiValueQueriesTest.java
##########
@@ -38,10 +38,7 @@
@Test(dataProvider = "orderByDataProvider")
public void testGroupByOrderByMVSQLResults(String query, List<Object[]>
expectedResults,
long expectedNumEntriesScannedPostFilter, DataSchema expectedDataSchema)
{
- Map<String, String> queryOptions = new HashMap<>(2);
Review comment:
all other tests use either full pql or full sql. this middle ground was
added by me when we were not ready.i dont see why we should keep this half
approach, now that we have the new endpoint ready
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
