mcvsubbu commented on a change in pull request #6774:
URL: https://github.com/apache/incubator-pinot/pull/6774#discussion_r611806017
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/api/resources/SegmentMetadataFetcher.java
##########
@@ -77,8 +80,13 @@ public static String getSegmentMetadata(SegmentDataManager
segmentDataManager, L
if (immutableSegment instanceof ImmutableSegmentImpl) {
ImmutableSegmentImpl immutableSegmentImpl = (ImmutableSegmentImpl)
immutableSegment;
Map<String, ColumnIndexContainer> columnIndexContainerMap =
immutableSegmentImpl.getIndexContainerMap();
- columnIndexMap =
getImmutableSegmentColumnIndexes(columnIndexContainerMap);
+ columnIndexMap = getSegmentColumnIndexes(columnIndexContainerMap);
Review comment:
Instead of all this type-casting, why not extend the SegmentDataManager
interface to include a method to get column indices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
