npawar commented on a change in pull request #6774:
URL: https://github.com/apache/incubator-pinot/pull/6774#discussion_r616150648
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/metadata/SegmentMetadataImpl.java
##########
@@ -554,7 +554,9 @@ public JsonNode toJson(@Nullable Set<String> columnFilter) {
String refreshTimeStr = _refreshTime != Long.MIN_VALUE ?
dateFormat.format(new Date(_refreshTime)) : null;
segmentMetadata.put("refreshTimeReadable", refreshTimeStr);
- segmentMetadata.put("segmentVersion", _segmentVersion.toString());
+ if(_segmentVersion!=null){
Review comment:
nit: formatting looks off here
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/IndexSegment.java
##########
@@ -86,6 +88,12 @@
*/
GenericRow getRecord(int docId, GenericRow reuse);
+ /**
+ * Returns a map of Column and its Index Container or null if there is no
such map
+ * @return Column Index Container Map
+ */
+ Map<String, ? extends ColumnIndexContainer> getIndexContainerMap();
Review comment:
if this is going to return null, mark this as `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
