Jackie-Jiang commented on a change in pull request #7255:
URL: https://github.com/apache/pinot/pull/7255#discussion_r686335787
##########
File path:
pinot-common/src/test/java/org/apache/pinot/common/tier/TierSegmentSelectorTest.java
##########
@@ -46,8 +45,8 @@ public void testTimeBasedSegmentSelector() {
// offline segment
String segmentName = "segment_0";
String tableNameWithType = "myTable_OFFLINE";
- OfflineSegmentZKMetadata offlineSegmentZKMetadata = new
OfflineSegmentZKMetadata();
- offlineSegmentZKMetadata.setSegmentName(segmentName);
+ SegmentZKMetadata offlineSegmentZKMetadata = new
SegmentZKMetadata(segmentName);
+
offlineSegmentZKMetadata.setSegmentType(CommonConstants.Segment.SegmentType.OFFLINE);
Review comment:
It is called within the constructor of `OfflineSegmentZKMetadata` and
`RealtimeSegmentZKMetadata` which is being cleaned up in this PR. It is already
deprecated and will be removed in the next release, so I didn't put it into the
constructor so that it can be easily cleaned up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
