Jackie-Jiang commented on a change in pull request #7255:
URL: https://github.com/apache/pinot/pull/7255#discussion_r686343622
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java
##########
@@ -377,10 +377,9 @@ public void run() {
try {
_segmentLogger.info("Marking current segment as completed in
Helix");
- RealtimeSegmentZKMetadata metadataToOverwrite = new
RealtimeSegmentZKMetadata();
+ SegmentZKMetadata metadataToOverwrite = new
SegmentZKMetadata(segmentZKMetadata.getSegmentName());
metadataToOverwrite.setTableName(_tableNameWithType);
-
metadataToOverwrite.setSegmentName(realtimeSegmentZKMetadata.getSegmentName());
- metadataToOverwrite.setSegmentType(SegmentType.OFFLINE);
Review comment:
Seems a typo to me. It does not matter actually because segment type is
already deprecated and is only used to determine the key for download url,
which does not apply to the HLC segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
