richardstartin commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-915962900
Rather than add another illegal reflective access to the codebase, can we take a step back? Why do we need to add the URL to `PluginClassLoader`'s `ClassLoader`? Presumably to create a delegation relationship between them, so what prevents a parent-child relationship here? I do appreciate this is addressing a regression, so there will be some desire for a "quick fix" but this needs to be balanced against making it harder for pinot to run on recent JDKs. Regardless of my future-proofing concerns, there should be a regression test which would have caught the regression in the first place, since it will cause cause some inconvenience if it regresses again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
