kkrugler commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-916426906
Hi @richardstartin - yes, it's a quick fix to a regression, so I'd like to get this in for the next release. It basically restores behavior on pre-Java 9 JREs to how it was previously. And I agree that it should be solvable in a more future-proof way. But note that the call to `_addUrlMethod.setAccessible(true)` should only happen when running with pre-Java 9 JREs. Separately the main issue with an appropriate regression test is that this problem only shows up when running with Hadoop and Spark. Tests for those absolutely should be added, but it's non-trivial to spin up a distributed Hadoop environment for these tests (needed to test proper class loading in the context of the map test). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
