richardstartin commented on a change in pull request #7513:
URL: https://github.com/apache/pinot/pull/7513#discussion_r721745598
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##########
@@ -45,30 +50,34 @@ public BitSlicedRangeIndexReader(PinotDataBuffer
dataBuffer) {
_min = dataBuffer.getLong(offset);
offset += Long.BYTES;
_offset = offset;
+ _max = metadata.hasDictionary()
Review comment:
Isn't it better to rely on the metadata? If information were stored in
two places it can be out of sync. This way the column metadata is the source of
truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]