Jackie-Jiang commented on a change in pull request #7513:
URL: https://github.com/apache/pinot/pull/7513#discussion_r721755402



##########
File path: 
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##########
@@ -45,30 +50,34 @@ public BitSlicedRangeIndexReader(PinotDataBuffer 
dataBuffer) {
     _min = dataBuffer.getLong(offset);
     offset += Long.BYTES;
     _offset = offset;
+    _max = metadata.hasDictionary()

Review comment:
       Here using either of them should be fine, especially when the creator is 
using the min/max value from the column metadata.
   In some places reading the metadata min/max value might cause precision loss 
because it involves ser/de of the values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to