mcvsubbu commented on a change in pull request #7878:
URL: https://github.com/apache/pinot/pull/7878#discussion_r766154068
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -163,17 +163,21 @@
@GET
@Produces(MediaType.APPLICATION_JSON)
@Path("/segments/{tableName}")
- @ApiOperation(value = "List all segments", notes = "List all segments")
+ @ApiOperation(value = "List all segments. The 'liveOnly' parameter is used
to get the list of segments"
Review comment:
All the internal implementation can be fixed, let us make sure we get
the parameter name right. Just suggesting here: How about
"includeIgnoredSegments"? You can write an explanation that segments are
ignored when the lineage information indicates that they are superseded by
newer segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
