jackjlli commented on a change in pull request #7878:
URL: https://github.com/apache/pinot/pull/7878#discussion_r766228422
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -163,17 +163,21 @@
@GET
@Produces(MediaType.APPLICATION_JSON)
@Path("/segments/{tableName}")
- @ApiOperation(value = "List all segments", notes = "List all segments")
+ @ApiOperation(value = "List all segments. The 'liveOnly' parameter is used
to get the list of segments"
Review comment:
There can be multiple kinds of segments that should be ignored. E.g.
like Jackie mentioned, segments in ERROR state or not served by servers can
also be ignored. Plus, the existing behavior should the default behavior, which
means that even if we introduce this `includeIgnoredSegments`, the value
should be false by default.
How about renaming it to `queryableSegments` and make it false by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
