mcvsubbu commented on a change in pull request #7896:
URL: https://github.com/apache/pinot/pull/7896#discussion_r769160523
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -624,14 +624,14 @@ public void run() {
_state = State.DISCARDED;
break;
case DEFAULT:
- success = buildSegmentAndReplace();
- if (success) {
+ try {
+ buildSegmentAndReplace();
Review comment:
OK, I realized that the addSegmentError is a method that adds all
segment errors. But my question still stands. When we detect a recoverable
error, do we still want to add an error? I don't think so. I think we should
call addSegmentError() API only when the error is unrecoverable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
