walterddr commented on pull request #7896: URL: https://github.com/apache/pinot/pull/7896#issuecomment-994262076
> @walterddr is there an issue created that has some details on what really happened? Or else, if you can describe what the problem was, that will help as well (maybe it was discussed in the chat channel, but it would help to have it in this PR). Thanks this was actually a very great question @mcvsubbu . so initially the PR was only to address the fact that 2 of the place where `_realtimeTableDataManager.addSegmentError` only logs a single string `"Could not build segment"`, with no stack trace attached. I later discover that this is because the several protected functions that returns "null" indicating the segment creation fail doesn't bubble up the stack trace therefore there's no stacktrace to report. Thanks for calling this out I think we deviated from the original purpose of this PR. I think we are now addressing a related but different (and bigger) issue. I can create an issue for what's being discussed here. But for the null-stacktrace issue we can simple move the reporting to where the actual exception was thrown. what do you guys think? (@sajjad-moradi @Jackie-Jiang ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
