snleee commented on a change in pull request #8071:
URL: https://github.com/apache/pinot/pull/8071#discussion_r792325151
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
##########
@@ -767,9 +768,11 @@ public void testSegmentReplacementForRefresh()
.getSegmentsFor(OFFLINE_SEGMENTS_REPLACE_TEST_REFRESH_TABLE_NAME,
true)),
new HashSet<>(Arrays.asList("s3", "s4", "s5")));
- // Start the new protocol with "forceCleanup = true" to check if 2
different proactive clean-up mechanism works:
+ // Start the new protocol (s3, s4, s5) -> (s9, s10, s11) with
"forceCleanup = true" to check if 2 different
+ // proactive clean-up mechanism works:
+ //
// 1. the previous lineage entry (s3, s4, s5) -> (s6, s7, s8) should be
"REVERTED"
- // 2. the older snapshot (s0, s1, s2) needs to be cleaned up because we
are about to upload the 3rd data snapshot
+ // 2. the older segments (s0, s1, s2) needs to be cleaned up because we
are about to upload the 3rd data snapshot
Review comment:
thanks! fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
