jtao15 commented on pull request #8240:
URL: https://github.com/apache/pinot/pull/8240#issuecomment-1049076369


   > > Even if `forceClean = true`, we should allow creating multiple lineages 
with empty `SegmentsFrom` list. I think we can add one more condition 
`!segmentsFrom.isEmpty()` on `L2886` to handle this. Also, we need to allow 
creating lineage entries with the same empty `SegmentsFrom` list on `L2922`.
   > 
   > Just adding an empty list check isn't sufficient, there could be two batch 
jobs pushing for the same target set of data. E.g. for refresh table, it's 
always not allowed to have such two batch jobs running at the same time, even 
though the `segmentFrom` field is empty. For append table, if two batch jobs 
are pushing the same data, one of them should be rejected or stopped.
   
   I thought creating two entries with empty `SegmentsFrom` will not happen for 
REFRESH table initially. But actually it can happen for empty tables. Agreed 
now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to