jackjlli commented on pull request #8240: URL: https://github.com/apache/pinot/pull/8240#issuecomment-1049094530
> hi @jackjlli @jtao15 thanks for the insights. I see currently conflict is checked with equality check like CollectionUtils.isEqualCollection. I wonder why it's not checking if there is overlap between segmentFrom sets instead? I'm thinking if I should check equality or overlap between segmentTo sets for the validation mentioned in your comments. Even if `segmentsTo` sets don't have any overlapping, both `segmentsTo` fields could still point to the same time range. Think of the refresh table, how do we make sure two batches don't overwrite each other if the segment names from two batch jobs are the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
