nizarhejazi commented on a change in pull request #8382:
URL: https://github.com/apache/pinot/pull/8382#discussion_r833756927
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java
##########
@@ -306,7 +306,7 @@ public static long now() {
* "-P6H3M" -- parses as "-6 hours and -3 minutes"
* "-P-6H+3M" -- parses as "+6 hours and -3 minutes"
*/
- @ScalarFunction
+ @ScalarFunction(nullableParameters = true)
Review comment:
`ago(periodString)` does not handle null because it cannot return null
(since return type is primitive `long`, not wrapper `Long`). I thought the idea
is to mark any function that cannot handle null because return type is
primitive (cannot return null) w/ nullableParameters.
Anyway, removed the annotation from all functions except fromDateTime and
dateTimeConvert since both can be used as ingestion transforms with input
columns that can take null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
