Jackie-Jiang commented on a change in pull request #8382:
URL: https://github.com/apache/pinot/pull/8382#discussion_r835542626
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/InbuiltFunctionEvaluator.java
##########
@@ -138,6 +149,15 @@ public Object execute(Object[] values) {
for (int i = 0; i < numArguments; i++) {
_arguments[i] = _argumentNodes[i].execute(values);
}
+ if (!_functionInfo.hasNullableParameters()) {
Review comment:
Yes, and that is the expected behavior. Then the record transformer can
fill the default value for this column
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/InbuiltFunctionEvaluator.java
##########
@@ -138,6 +149,15 @@ public Object execute(Object[] values) {
for (int i = 0; i < numArguments; i++) {
_arguments[i] = _argumentNodes[i].execute(values);
}
+ if (!_functionInfo.hasNullableParameters()) {
Review comment:
Yes, and that is the desired behavior. Then the record transformer can
fill the default value for this column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
