Jackie-Jiang commented on a change in pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#discussion_r836705246
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/DictionaryBasedAggregationOperator.java
##########
@@ -44,6 +44,8 @@
import org.apache.pinot.spi.data.FieldSpec;
import org.apache.pinot.spi.utils.ByteArray;
+import static
org.apache.pinot.core.operator.query.AggregationOperatorUtils.toDouble;
Review comment:
Sure, I'm open to other conventions as long as it improves readability.
Pinot Style mostly follows the [LinkedIn Java Style
Guide](https://www.linkedin.com/pulse/coding-standard-programming-best-practices-java-part-1-david-rios/)
(wildcard and static import is not permitted) which is mostly extended from
[Google Java Style Guide](https://google.github.io/styleguide/javaguide.html).
The reason for certain rules that seems too strict and cause ugly code is to
prevent developers from misusing them and causing poor readability. We can open
a separate issue to discuss it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
