richardstartin commented on a change in pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#discussion_r836808302
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java
##########
@@ -64,6 +64,10 @@
DISTINCTCOUNTHLLMV, DISTINCTCOUNTRAWHLL, DISTINCTCOUNTRAWHLLMV,
SEGMENTPARTITIONEDDISTINCTCOUNT,
DISTINCTCOUNTSMARTHLL);
+ // DISTINCTCOUNT excluded because consuming segment metadata contains
unknown cardinality when there is no dictionary
Review comment:
I just merged them in the end
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/ExplainPlanQueriesTest.java
##########
@@ -505,7 +505,7 @@ public void testSelectAggregate() {
result1.add(new Object[]{"AGGREGATE_METADATA", 2, 1});
check(query1, new ResultTable(DATA_SCHEMA, result1));
- String query2 = "EXPLAIN PLAN FOR SELECT min(invertedIndexCol1) FROM
testTable";
+ String query2 = "EXPLAIN PLAN FOR SELECT
distinctcounthll(invertedIndexCol1) FROM testTable";
Review comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
