Jackie-Jiang commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848865538
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -415,10 +421,12 @@ private ForwardIndexReaderContext getReaderContext() {
}
void readDictIds(int[] docIds, int length, int[] dictIdBuffer) {
+ Tracing.activeRecording().setInputDataType(_dataType, _singleValue);
Review Comment:
So the contract here is that `InvocationRecording` implementation should not
assume the recording methods are not called when it is disabled. Might worth
adding it into the javadoc of the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
